Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add camera mod to diagnostic hud #32254

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add camera mod to diagnostic hud #32254

wants to merge 4 commits into from
+30 −4

Conversation

ArZarLordOfMango
Copy link
Contributor

@ArZarLordOfMango ArZarLordOfMango commented Sep 17, 2024 •
edited
Loading

About the PR

Added camera mod to diagnostic hud. That allow you to look at the world as an AI (they don't allow you to look through walls, just give you a “noise” effect). You can also turn them on and off by action. They're can researched in the experimental branch.

Why / Balance

Playing as an AI, sometimes it can be difficult to explain where to put the cameras to get a better field of view. Especially if you don't know the map.

Technical details

Media

Screenshot 2024-09-21 211935
Screenshot 2024-09-21 212019
Screenshot 2024-09-21 212108

Requirements

Breaking changes

Changelog
🆑

  • add: Added camera mod to diagnostic hud. Allows displays camera view ranges.

@github-actions github-actions bot added Changes: No C# No C# knowledge is required to review or fix this item. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. S: Needs Review Indicates an item that requires new reviews. S: Merge Conflict Indicates an item has merge conflicts that need to be addressed. labels Sep 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

RSI Diff Bot; head commit 72851b6 merging into 9afc786
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Eyes/Glasses/camera.rsi

State Old New Status
equipped-EYES Added
icon-on Added
icon Added
inhand-left Added
inhand-right Added
on-equipped-EYES Added

Edit: diff updated after 72851b6

@muburu
Copy link
Contributor

muburu commented Sep 17, 2024

it'd be funny of the sprite was like a blocky VR headset

@Everturning
Copy link

i love this because it both buffs traitors and AI and thats hilarious to me

@Everturning
Copy link

wait the sprite is called just "camera.rsi" I'm in no way a dev but that does seem like it'd cause issues

@github-actions github-actions bot removed the S: Merge Conflict Indicates an item has merge conflicts that need to be addressed. label Sep 17, 2024
@lzk228
Copy link
Contributor

lzk228 commented Sep 17, 2024

would be neat to make not AI overlay, but like make visionless zone darkened or something

@slarticodefast slarticodefast added the S: Undergoing Maintainer Discussion This item is currently going through an extended discussion amongst maintainers, as per procedure. label Sep 17, 2024
@HerCoyote23
Copy link
Contributor

HerCoyote23 commented Sep 19, 2024 •
edited
Loading

I'd recommend you change the item description to something like:
Advanced visor which displays camera view ranges. Useful for working with the Station AI.

as the current:
Advanced glasses are designed to look like through cameras. Useful for working with Station AI.

is grammar-wise pretty rough.

@slarticodefast
Copy link
Member

Hey, I brought this up for maintainer discussion. Instead of making this its own item, could you add this functionality to the diagnostic HUD instead?

@ArZarLordOfMango ArZarLordOfMango changed the title Add camera visor Add camera mod to diagnostic hud Sep 21, 2024
@slarticodefast
Copy link
Member

Did some more testing and found a bug:
Take the glasses into your hands, activate them and drop them. You will keep the overlay.

Screenshot (291)

Also the shadows look a little weird sometimes when there is static, but I'm not sure how this could be prevented ecxept by allowing you to look through walls (assuming there is a camera), which would be quite powerful.

Screenshot (290)
Screenshot (289)

@slarticodefast slarticodefast added S: Awaiting Changes Indicates an item is awaiting changes. and removed S: Needs Review Indicates an item that requires new reviews. labels Sep 22, 2024
@SlamBamActionman SlamBamActionman added the S: Untriaged Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmoGarbage404 EmoGarbage404 Awaiting requested review from EmoGarbage404 EmoGarbage404 is a code owner

Assignees
No one assigned
Labels
Changes: No C# No C# knowledge is required to review or fix this item. Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design. S: Awaiting Changes Indicates an item is awaiting changes. S: Undergoing Maintainer Discussion This item is currently going through an extended discussion amongst maintainers, as per procedure. S: Untriaged Indicates an item has not been triaged and doesn't have appropriate labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ArZarLordOfMango @muburu @Everturning @lzk228 @HerCoyote23 @slarticodefast @SlamBamActionman